Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix methods that use sp_fkeys #490

Merged
merged 15 commits into from
Sep 15, 2017
Merged

fix methods that use sp_fkeys #490

merged 15 commits into from
Sep 15, 2017

Conversation

xiangyushawn
Copy link
Contributor

fix issue #467

This PR creates 2 temporary tables to store resultsets returned from sp_fkeys and sys.foreign_keys, then uses RIGHT JOIN operation and UPDATE operation to correct and return the values for DELETE_RULE and UPDATE_RULE.

This is the best solution I can think of in term of performance and memorization. Please let me know if you have any better ideas or suggestions

@codecov-io
Copy link

codecov-io commented Sep 12, 2017 •
edited
Loading

Codecov Report

Merging #490 into dev will increase coverage by 0.15%.
The diff coverage is 90.9%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #490      +/-   ##
============================================
+ Coverage     46.37%   46.52%   +0.15%     
+ Complexity     2212     2211       -1     
============================================
  Files           108      108              
  Lines         25231    25272      +41     
  Branches       4173     4176       +3     
============================================
+ Hits          11700    11758      +58     
+ Misses        11524    11484      -40     
- Partials       2007     2030      +23
Flag Coverage Δ Complexity Δ
#JDBC41 46.24% <90.9%> (ø) 2199 <2> (-3) ⬇️
#JDBC42 46.38% <90.9%> (+0.11%) 2206 <2> (-2) ⬇️
Impacted Files Coverage Δ Complexity Δ
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 35.59% <90.9%> (+5.89%) 55 <2> (+6) ⬆️
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 54.21% <0%> (-1.21%) 30% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (-1.13%) 16% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.81% <0%> (-0.53%) 242% <0%> (-4%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 42.2% <0%> (-0.22%) 46% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.51% <0%> (-0.2%) 239% <0%> (+1%)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 77.62% <0%> (-0.17%) 4% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.36% <0%> (-0.11%) 130% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.24% <0%> (+0.06%) 0% <0%> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 45.88% <0%> (+0.07%) 275% <0%> (+1%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8960b85...d1eb934. Read the comment docs.

@AfsanehR-zz AfsanehR-zz added this to the 6.3.3 milestone Sep 14, 2017
@xiangyushawn xiangyushawn merged commit 7fb24f2 into microsoft:dev Sep 15, 2017
@xiangyushawn xiangyushawn deleted the sp_fkeys-fix branch September 15, 2017 20:22
@woehrl01 woehrl01 mentioned this pull request Mar 26, 2018
Closed
@probert94 probert94 mentioned this pull request May 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AfsanehR-zz AfsanehR-zz AfsanehR-zz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@xiangyushawn @codecov-io @AfsanehR-zz @msftclas